Matalkbt codereview #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bt-codereview # Conflicts: # src/main/java/com/enterprise/fastfoodapplication/service/FoodServiceStub.java
discospiff
reviewed
Oct 12, 2021
| @Autowired | ||
|
|
discospiff
reviewed
Oct 12, 2021
Comment on lines
+17
to
+20
| /** | ||
| * | ||
| * @return | ||
| */ |
There was a problem hiding this comment.
Only add JavaDoc if it is providing value over and above what can be read from the method.
discospiff
reviewed
Oct 12, 2021
Comment on lines
+57
to
+60
| /** | ||
| * | ||
| * @param order | ||
| */ |
There was a problem hiding this comment.
Only add JavaDoc if it is providing value over and above what can be read from the method.
discospiff
reviewed
Oct 12, 2021
Comment on lines
+65
to
+66
| foodService.createFoodItem(food); | ||
| Food createdFood = foodService.getFoodItemById(Integer.parseInt(food.getFoodId())); |
There was a problem hiding this comment.
What is the purpose of this change? Cite sources that show how this aligns with best practices.
discospiff
reviewed
Oct 12, 2021
| Food createFoodItem(Food food) throws Exception; | ||
| void createFoodItem(Food food); |
There was a problem hiding this comment.
Be wary of changing a contract as part of a code review.
|
I don't see sufficient technical debt reduction in this branch to justify a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub definitely needs more developed to function. I left that up to you guys for the next sprint, as that would be a good goal. Use variables in the stub to actually develop those useful functions you made instead of hardcoding values to make the tests pass. I did a little clean up. But, it looks like a good outline of everything so far.