Add logging to FastFoodApp controller, logging template to applicatio… #7
Conversation
|
To reduce overall technical debt, rename CartOrder to Order, then delete ShoppingCart class and ShoppingCartController, as well as OrderHistory and OrderHistoryController. Differentiate between the order statuses by adding a Status field, Differentiate recent orders by returning based on OrderID. Could add CartID as primary key until order is actually placed, then populate and use OrderID. Adding endpoints as need for OrderHistory, etc. Can use the same method names for updates etc, by adding an interface and then specify the implementation of those methods in the class. |
|
Removed contructors in order class as they were not needed because of lombok. Added javadoc to Order class |
|
The program is aesthetically pleasing. |
| @@ -70,8 +70,8 @@ public ResponseEntity fetchAllFood(){ | |||
| return new ResponseEntity(allFood, headers, HttpStatus.OK); | |||
| } catch (Exception e) { | |||
| e.printStackTrace(); | |||
| return new ResponseEntity(HttpStatus.INTERNAL_SERVER_ERROR); | |||
| /*TO DO Logging*/ | |||
| logger.warning(e.getMessage()); | |||
| private String orderId; | ||
| private String cartId; |
There was a problem hiding this comment.
Are these used anywhere?
This appears to be an incomplete feature. In a code review, focus on reducing technical debt of existing code. Avoid adding new, incomplete functionality .
- Only features that meet the Definition of Done should be merged to Master.
- Unused code is clutter, which increases technical debt.
|
Logging: definitely a good idea. For the class names, I'm not clear on how changing them reduces technical debt. Cite sources to be sure. |
Added logging, logging leve, and logging templates to application.properties so different levels of loggin can be done from application properties.
Put the following in your application.properties if not including in version control:
logging.level.org.springframework=DEBUG
logging.level.com.howtodoinjava=DEBUG
#output to a temp_folder/file
logging.file.name=${java.io.tmpdir}/application.log
Logging pattern for the console
logging.pattern.console= %d{yyyy-MM-dd HH:mm:ss} - %msg%n
Logging pattern for file
logging.pattern.file= %d{yyyy-MM-dd HH:mm:ss} [%thread] %-5level %logger{36} - %msg%