Matalkbt code review2 #9
Conversation
…mports. It's important to use the proper annotations to identify the layer instead of using the general annotation.
… the logger to log errors. It's better practice to use the logger to log exceptions/errors. Added in the exception as reference to the error logged.
…ences the div a little lower. Just a nice feature for users to easily navigate to what they are looking for. Also, added a design recommendation for the shopping cart page.
| <!-- As a recommendation, you can have the 'add' button trigger a Modal to select the specifics for each type of food. | ||
| This helps prevent the unusual text display as seen here. This however is a design choice, and the course is more about | ||
| backend than front end development.--> |
There was a problem hiding this comment.
Putting conversation/discussion in code comments is bad practice, as that clutters up the source code and does not belong in source code files. I mentioned that in the code review instructions. Discussion and comments are very good, but have that in the appropriate place, which is in the "Files Changed" tab in the pull request in GitHub (which is where I am writing this and you are reading this). That way, you can have a conversation with replies, right where the code is happening, and without cluttering up the source code itself.
| @@ -54,7 +54,7 @@ <h4> A restaurant is a place where you can enjoy the food you like with your fam | |||
|
|
|||
| <button class="btn btn-info"> Create Your Order </button> | |||
|
|
|||
| <p3> <br>Don't have an account with us? Sign Up </p3> | |||
| <p3> <br>Don't have an account with us? <a href="#signUp">Sign Up</a> </p3> | |||
There was a problem hiding this comment.
Shouldn't a # href point to an a tag?
There was a problem hiding this comment.
When we # it points to a corresponding id on the page. So it just jumps down the page to the already created div. It could point to an a tag. Is it better practice to do this?
|
From this review, I'd harvest the logging. Logging is always a good idea. |
The application is looking great so far! I love seeing the progress. Only a few minor code changes from me.