CORPORATION: Add a new API to sell a division #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0sboots
reviewed
Apr 8, 2024
There was a problem hiding this comment.
The refactoring here looks good.
However, I'm slightly hesitant about sellCorporation. In the past, there were cheese stats for BN3 that revolved around repeatedly selling your corp; those might still exist, or might come back in the future. I'm also not sure what the method is good for except cheese strats.
sellDivision is similar, but probably OK.
|
After discussing with maintainers and other contributors, I decide to remove |
catloversg
changed the title
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
May 5, 2024
Also refactoring around use of "player" variable (whether it is capitalized or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 APIs:
selfFunddoes NOT have a default value.Other changes:
Playerfromimport { Player as player }toimport { Player }in many places.Player's import to@playerin many places.SellCorporationModal.tsx. Its implementation is merged withCreateCorporationModal.tsx.