Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix Text Effect Preventing Company Name Updates #1828

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Nerdpie
Copy link

@Nerdpie Nerdpie commented Dec 8, 2024

Closes #1827

Testing steps:

  • Used Dev menu to backdoor two servers, get stats to take jobs
  • Got a position with the two companies who were backdoored, and one that was not
  • Under Options, disabled Text Effects
  • Went to Jobs page
  • Pressed 'Previous Job' and 'Next Job'
  • Observed that the company name updated properly for all cases (backdoor-> backdoor, backdoor->secure, secure-> backdoor)

@catloversg
Copy link
Contributor

catloversg commented Dec 8, 2024

Note that "Got a position with the two companies who were backdoored, and one that was not" is confusing when testing. This bug happens when you switch between companies that were backdoored.

Reproducible steps:

  • Load a clean save file.
  • Apply to Joe's Guns and FoodNStuff.
  • Install backdoors on joesguns and foodnstuff.
  • Options -> Interface -> Disable text effects.
  • Switch to the Job tab and switch between those jobs.

Save file: pr 1828.gz

@Nerdpie
Copy link
Author

Nerdpie commented Dec 11, 2024

Apologies for the vague step; I was thinking more generally, rather than a singular example to reproduce the issue. I was also trying to convey that the bug does not show up when switching between jobs for a company that was backdoored, and one that was not.

I'm also not quite satisfied with the PR title, but I was trying to keep it concise... any feedback there is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Text Effects Breaks Company Names
2 participants