BUGFIX: Tail log does not render multiline logs properly in edge cases #1838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRE:
In pre-v2.7.0, "a" and "b" are printed on 2 lines. In v2.7.0, they are printed on the same line. This is a regression bug caused by the
display: "inline-block"
style added in #1703.inline-block
is supposed to ensure that line height is displayed properly. However, when I test many combinations of tail font size and line height, it seems that we don't need to useinline-block
.Test code 1:
Test code 2 (provided by @G4mingJon4s): https://gist.github.com/G4mingJon4s/ba804da307e356268ee1f01f20b4af19
Screenshots:
Tail font size 16, line height 1.5
Tail font size 20, line height 1.5
Tail font size 20, line height 2
Tail font size 25, line height 3