Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chat list and dialog #111

Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat: chat list and dialog #111

merged 2 commits into from
Apr 8, 2024

Conversation

gaboesquivel
Copy link
Member

@gaboesquivel gaboesquivel commented Apr 8, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new chat interface component for better user interaction.
    • Enhanced thread dialog with additional components for a more interactive experience.
    • Added new properties to various components to support enhanced functionalities and layouts.
  • Refactor

    • Updated naming conventions for clarity and consistency across components.
    • Refined the thread and chat list rendering process for improved user experience.
    • Optimized layout structures for better responsiveness and user navigation.
  • Style

    • Adjusted padding and margin in several components for a more polished and user-friendly interface.
  • Chores

    • Removed unused code and comments to clean up the codebase.
    • Updated ESLint rules to ensure code quality and consistency.

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
masterbots ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 10:54pm

Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Walkthrough

The recent updates to the masterbots.ai platform involve a series of refinements across its application structure and components. Key changes include renaming functions and interfaces to better reflect their purposes, enhancing the chat interface and thread display, and improving layout and styling for a more intuitive user experience. Additionally, the introduction of new properties and components suggests a deeper integration of chat functionalities, aiming for a smoother interaction flow within the platform.

Changes

Files Change Summary
.../app/(browse)/[category]/[threadId]/page.tsx,
.../app/c/[chatbot]/page.tsx,
.../app/c/page.tsx,
.../components/routes/c/chat-input.tsx,
.../components/routes/c/new-chat.tsx
Renamed functions and interfaces; adjusted chat functionalities.
.../app/b/[id]/layout.tsx Removed commented-out TODO code.
.../app/c/layout.tsx Updated layout structure; introduced BrowseProvider.
.../components/layout/header.tsx Adjusted header layout and styling.
.../components/routes/c/chat-input-2.tsx Introduced ChatInputTT component.
.../components/routes/c/chat-list.tsx,
.../components/routes/c/chat.tsx
Modified chat message display mechanism.
.../components/routes/c/sidebar/... Updated href attributes and sidebar styling.
.../components/shared/... Added new props and adjusted styling in shared components.
packages/config-eslint/next.js Added ESLint rule for TypeScript.

🐰✨
Changes abound, both big and small,
In the land of code, we've touched it all.
From chat to threads, with care we hop,
Ensuring every byte does not flop.
With every tweak and every fix,
We craft a world where users mix.
So here's to change, may it delight,
Our digital realm, ever so bright. 🌟
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gaboesquivel gaboesquivel merged commit edea67a into develop Apr 8, 2024
3 of 4 checks passed
@gaboesquivel gaboesquivel deleted the chat-thread-list branch April 8, 2024 22:53
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7ad6cff and 62ffb32.
Files ignored due to path filters (1)
  • bun.lockb is excluded by !bun.lockb
Files selected for processing (16)
  • apps/masterbots.ai/app/(browse)/[category]/[threadId]/page.tsx (2 hunks)
  • apps/masterbots.ai/app/b/[id]/layout.tsx (1 hunks)
  • apps/masterbots.ai/app/c/[chatbot]/page.tsx (3 hunks)
  • apps/masterbots.ai/app/c/layout.tsx (1 hunks)
  • apps/masterbots.ai/app/c/page.tsx (2 hunks)
  • apps/masterbots.ai/components/routes/c/chat-input-2.tsx (1 hunks)
  • apps/masterbots.ai/components/routes/c/chat-input.tsx (3 hunks)
  • apps/masterbots.ai/components/routes/c/chat-list.tsx (2 hunks)
  • apps/masterbots.ai/components/routes/c/chat.tsx (3 hunks)
  • apps/masterbots.ai/components/routes/c/new-chat.tsx (4 hunks)
  • apps/masterbots.ai/components/routes/c/sidebar/sidebar-responsive.tsx (1 hunks)
  • apps/masterbots.ai/components/shared/browse-input.tsx (1 hunks)
  • apps/masterbots.ai/components/shared/thread-dialog.tsx (2 hunks)
  • apps/masterbots.ai/components/shared/thread-heading.tsx (3 hunks)
  • apps/masterbots.ai/components/shared/thread-list.tsx (3 hunks)
  • packages/config-eslint/next.js (1 hunks)
Files skipped from review as they are similar to previous changes (15)
  • apps/masterbots.ai/app/(browse)/[category]/[threadId]/page.tsx
  • apps/masterbots.ai/app/b/[id]/layout.tsx
  • apps/masterbots.ai/app/c/[chatbot]/page.tsx
  • apps/masterbots.ai/app/c/layout.tsx
  • apps/masterbots.ai/app/c/page.tsx
  • apps/masterbots.ai/components/routes/c/chat-input-2.tsx
  • apps/masterbots.ai/components/routes/c/chat-input.tsx
  • apps/masterbots.ai/components/routes/c/chat.tsx
  • apps/masterbots.ai/components/routes/c/new-chat.tsx
  • apps/masterbots.ai/components/routes/c/sidebar/sidebar-responsive.tsx
  • apps/masterbots.ai/components/shared/browse-input.tsx
  • apps/masterbots.ai/components/shared/thread-dialog.tsx
  • apps/masterbots.ai/components/shared/thread-heading.tsx
  • apps/masterbots.ai/components/shared/thread-list.tsx
  • packages/config-eslint/next.js
Additional comments not posted (5)
apps/masterbots.ai/components/routes/c/chat-list.tsx (5)

1-3: Consider organizing imports for better readability.

Grouping imports (e.g., external libraries, type imports, hooks, and local components) can enhance code readability and maintenance.


Line range hint 9-17: Review the necessity of the MessagePair interface.

Given the shift to using an "Accordion" component for message display, verify if the MessagePair interface is still required. If not, consider removing it to clean up the codebase.


46-52: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [19-47]

Revisit commented-out React.useEffect hook.

The commented-out React.useEffect hook suggests a previous approach to managing message pairs. If this logic is no longer needed due to the new "Accordion" implementation, consider removing the commented code to avoid confusion.


46-52: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [19-47]

Ensure isNewResponse hook usage aligns with new functionality.

The useThread hook's isNewResponse is included but not visibly used in the provided code snippet. Verify its purpose and ensure its usage aligns with the new chat message display logic.


46-52: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [19-47]

Evaluate the impact of removing iteration logic on functionality.

The removal of iteration over message pairs for rendering chat messages might have implications on the chat functionality. Ensure that the new "Accordion" component adequately supports all intended features, such as message grouping and response handling.

</ChatAccordion>
</div>
))}
Accordion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace placeholder text with the Accordion component implementation.

The current implementation only includes the placeholder text "Accordion". Replace this with the actual Accordion component to render chat messages as intended.

Copy link

github-actions bot commented Apr 8, 2024

⚡️ Lighthouse report

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617306845-16987.report.html

Category Score
🟠 Performance 54
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617307260-56394.report.html

Category Score
🟠 Performance 69
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617307642-18621.report.html

Category Score
🟠 Performance 55
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617308047-19403.report.html

Category Score
🟠 Performance 89
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 76
🔴 PWA 38

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617308662-61428.report.html

Category Score
🟠 Performance 57
🟢 Accessibility 95
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-au2eo0zjp-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712617309089-95917.report.html

Category Score
🟠 Performance 56
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

gaboesquivel added a commit that referenced this pull request Apr 9, 2024
* devops: force deployment

* devops: force deployment

* devops: force deployment

* devops: update cloudbuild.yml

* devops: cloud logging only

* devops: remove cloudbuild.yml

* chore: update bunlock

* feat: browse as homepage, work early access (#62)

* feat: browse as home

* feat: browse as home

* feat: remove tabs

* feat: supabase auth (#63)

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: supabase auth

* feat: pro form

* devops:  lighthouse reports on prs (#64)

* devops:  lighthouse reports on prs

* chore: cleanup

* devops: lighthouse ci (#65)

* devops:  lighthouse reports on prs

* chore: cleanup

* chore: test lighthouse ci

* devops: lighthouse reports on pr

* devops: use zentered/vercel-preview-url

* devops: lighthouse ci github action (#66)

* chore: test lighthouse ci

* devops: fix version on github actions

* chore: cleanup

* devops: debug lighthouse github action (#67)

* chore: test lighthouse ci

* devops: debug github actions

* devops: correct project id on github actions (#69)

* devops: debug github actions

* devops: correct project id

* devops: correct vercel team id (#70)

* devops: debug github actions

* devops: correct vercel team id

* devops: debug github actions (#71)

* devops: debug github actions

* devops: use actions/checkout v4

* devops: add protocol to lhci url

* devops: use foo-software/lighthouse-check-action (#72)

* devops: debug github actions

* devops: debug github actions

* devops: use foo-software/lighthouse-check-action

* devops: lhci budget path (#73)

* devops: debug github actions

* devops: lhci budget path

* devops: disable lhci budget (#74)

* devops: debug github actions

* devops: disable lhci budget

* devops: run lhci on bot and user landings (#75)

* devops: debug github actions

* devops: run lhci on bot and user landings

* devops: run lhci on bot and user landings (#76)

* devops: debug github actions

* devops: run lhci on bot and user landings

* devops: run lhci on bot and user landings

* devops: run lhci on bot and user landings (#77)

* devops: debug github actions

* devops: run lhci on bot and user landings

* devops: debug lhci results comment (#78)

* devops: debug github actions

* devops: debug lhci results comment

* devops: debug lhci results comment (#79)

* devops: debug github actions

* devops: debug lhci results comment

* feat: thread landing (#80)

* devops: debug lhci results comment

* feat: thread landing

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#83)

* chore: cleanup

* devops: debug lhci results comment

* devops: debug lhci results comment (#84)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#85)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#86)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#88)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#89)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: lhci results table comment

* devops: debug lhci results comment

* devops: lhci results table comment (#90)

* devops: lhci results table comment

* devops: lhci results table comment (#91)

* devops: lhci results table comment

* devops: lhci results table comment

* devops: lhci results table comment

* devops: debug lhci results comment (#92)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#93)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: lhci results table comment (#94)

* devops: debug lhci results comment

* devops: debug lhci results comment (#95)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment (#96)

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: debug lhci results comment

* devops: lhci results table comment

* devops: lhci results table comment

* devops: debug lhci results comment

* devops: lhci results table comment (#98)

* chore: cleanup

* devops: lhci results table comment

* devops: test lhci results comment (#99)

* devops: test lhci results comment

* devops: test lhci results comment

* devops: test lhci results comment

* feat: shortener

* feat: supabase auth

* fix: hasura jwt secret on local env

* fix: hasura jwt secret on local env

* chore: user profile cookie

* chore: user profile cookie

* chore: user profile cookie

* chore: user profile cookie

* feat: supabase auth, github oauth, session cookies

* devops: config pkgs, eslint, prettier, tailwind, ts (#101)

* devops: config pkgs, eslint, prettier, tailwind, ts

* devops: config pkgs, eslint, prettier, tailwind, ts

* devops: config pkgs, eslint, prettier, tailwind, ts

* devops: config pkgs, eslint, prettier, tailwind, ts

* devops: remove first comment on lhci action

* devops: fix eslint action

* chore: ssr on browse, supa types, updated actions (#103)

* chore: browse ssr improvements, supabase db types

* chore: fix eslint

* devops: lhci on pr

* feat: thread ui dialog and ssr in public pages (#105)

* feat: thread dialog ui

* feat: thread dialog ui

* feat: thread dialog ui

* feat: ssr and layout improvements on u and b routes

* fix: correct thread number

* feat: ssr and layout improvements on u and b routes

* feat: global categories nav

* chore: move shared components

* feat: copy shortlink

* chore: disable getUserProfile

* perf: only 25 items on first render

* perf: only 20 items on first render

* fix: supabase ssr bug (#106)

* devops: wait 2 minutes before running lhci (#107)

* feat: load only 15 more

* fix: auth issues

* devops: wait 2 minutes before running lhci

* devops: wait before lhci, fix vercel build (#108)

* feat: load only 15 more

* fix: auth issues

* devops: wait 2 minutes before running lhci

* chore: cleanup

* fix: header session bug

* fix: chat auth bug (#109)

* fix: chat auth bug

* fix: chat auth bug

* fix: chat auth bug

* fix: chat navigation (#110)

* fix: icon size

* fix: chat navigation

* feat: chat list and dialog (#111)

* feat: chat lists and dialog

* feat: chat lists and dialog

* feat: dialog chat input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant