Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(masterbots.ai): dynamic og image design and metadata #221

Closed
wants to merge 3 commits into from
Closed

feat(masterbots.ai): dynamic og image design and metadata #221

wants to merge 3 commits into from

Conversation

AndlerRL
Copy link
Contributor

Cherry-Pick From PR #215 . Branch Based On The search Branch.

  • feat: added og api endpoint

  • feat: design og image for dark mode

  • fix: file formated

  • fix: amend og image to pick current theme color and adapt

  • feat: added custom metadata to thread page

  • feat: added custom metadata to bot page

  • fix: clean up

  • fix: move bg to a component

  • fix: move og-image design to a component

  • fix: use variable for URL

  • fix: to slug func

  • ⚡️ Move and clean up UrlToSlug

  • fix(masterbots.ai): zod dependecy

  • fix: type error

  • fix: type error for metadata

  • fix: clean and build fix

@sheriffjimoh @AndlerRL
feat(masterbots.ai): consistent og image style design and dynamic met…
2be0044 
…adata (#215)

* feat: added og api endpoint

* feat: design og image for dark mode

* fix: file formated

* fix: amend  og image to pick current theme color and adapt

* feat: added custom metadata to thread page

* feat: added custom metadata to bot page

* fix: clean up

* fix: move bg to a component

* fix: move og-image design  to a component

* fix: use variable for URL

* fix: to slug func

* ⚡️ Move and clean up UrlToSlug

* fix(masterbots.ai): zod dependecy

* fix: type error

* fix: type error for metadata

* fix: clean and build fix

---------

Co-authored-by: Roberto Lucas <andler.dev@gmail.com>
@AndlerRL AndlerRL requested a review from gaboesquivel May 20, 2024 18:18
@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
masterbots ❌ Failed (Inspect) May 21, 2024 5:48am

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 20, 2024 •
edited
Loading

Important

Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

AndlerRL
AndlerRL commented May 20, 2024
View reviewed changes
apps/masterbots.ai/app/b/[id]/[threadId]/page.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page usage example: https://masterbots.ai/technology/ff0838e1-efd9-4046-843b-d413cbfa70ff

Copy link
Contributor Author

@AndlerRL AndlerRL May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking now that this change is from the b folder, so we have also this: https://masterbots.ai/b/technology/ff0838e1-efd9-4046-843b-d413cbfa70ff . I think we should be using instead masterbots.ai/b/[id]/[thread_id] for sharing and site map in general, since it makes more sense when navigating the bot threads, mainly because the focus is the perspective of blogs created by the Ai.

Let me know what you think, @gaboesquivel .

cc - @merivercap @TopETH

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

⚡️ Lighthouse report

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270633618-47212.report.html

Category Score
🟢 Performance 91
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270634052-1600.report.html

Category Score
🟢 Performance 91
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270634369-69125.report.html

Category Score
🟢 Performance 91
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270634677-5679.report.html

Category Score
🟢 Performance 90
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270634918-65260.report.html

Category Score
🟢 Performance 93
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

Page: https://masterbots-qgpxnx2c5-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1716270635216-98514.report.html

Category Score
🟢 Performance 90
🟢 Accessibility 93
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 38

@gaboesquivel
Copy link
Member

@AndlerRL build is failing

gaboesquivel
gaboesquivel requested changes May 21, 2024
View reviewed changes
Copy link
Member

@gaboesquivel gaboesquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vercel build fails

@AndlerRL AndlerRL self-assigned this May 27, 2024
@AndlerRL AndlerRL marked this pull request as draft May 29, 2024 15:12
@AndlerRL
Copy link
Contributor Author

AndlerRL commented Oct 3, 2024

MB current status is superior to this version (and branch). Search implementations will be made by using along with the ICL that is currently in develop by one of our collaborators. This ICL will vector the data and relate the search with the content that exist in main database and the (ICL) metadata.

Search is not yet at the current MB roadmap but for later development. If we have to work on search, it will be on a version different from this one. Closing Draft PR.

@AndlerRL AndlerRL closed this Oct 3, 2024
@AndlerRL AndlerRL mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaboesquivel gaboesquivel gaboesquivel requested changes

Assignees

@AndlerRL AndlerRL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndlerRL @gaboesquivel @sheriffjimoh