Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CI #47

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Test CI #47

merged 1 commit into from
Sep 10, 2024

Conversation

ValuedMammal
Copy link
Collaborator

No description provided.

@ValuedMammal ValuedMammal force-pushed the ci/test-ci branch 2 times, most recently from 545603a to b361af8 Compare September 10, 2024 02:34
@rustaceanrob
Copy link
Collaborator

Looks good, but let's use cargo clippy --all-targets to also lint tests and examples

@ValuedMammal
Copy link
Collaborator Author

I basically took what bdk uses just to get something working, but we can iterate on this as needed

@rustaceanrob
Copy link
Collaborator

makes sense, mostly referring to the changes in tests/client.rs that remove the use of first. could you rebase and pick up the changes on master for that?

@ValuedMammal
Copy link
Collaborator Author

As far as I know changing first to iter().next() was a fix for msrv

@ValuedMammal ValuedMammal merged commit ff57a06 into master Sep 10, 2024
2 checks passed
@rustaceanrob
Copy link
Collaborator

i see, rust 1.66. thanks

@ValuedMammal ValuedMammal deleted the ci/test-ci branch September 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValuedMammal @rustaceanrob