Skip to content

Commit

Permalink
Merge #157: ci: pin msrv dep version for rustls
Browse files Browse the repository at this point in the history
b0a1bfb ci: pin msrv dep version for rustls (Steve Myers)

Pull request description:

  I'm not thrilled about having to pin `rustls` to meet our MSRV, but we need to make a new release and can't count on rustls/rustls#2239 being accepted by the `rustls` team.

ACKs for top commit:
  luisschwab:
    utACK b0a1bfb
  ValuedMammal:
    utACK b0a1bfb
  oleonardolima:
    ACK b0a1bfb

Tree-SHA512: 1f37b423f3e10a7e3fa4e2072d5ad38b96341a91f78c1bcffc011dedc08071bd176b556646e40e635c3b558e6b771a4a7baa85b10d14da64d2cd385a69342ee4
  • Loading branch information
notmandatory committed Nov 26, 2024
2 parents 6e2a9b4 + b0a1bfb commit f00b999
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/cont_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
uses: dtolnay/rust-toolchain@stable
with:
toolchain: ${{ matrix.rust }}
- name: Pin dependencies for MSRV
if: matrix.rust == '1.63.0'
run: |
cargo update -p rustls --precise "0.23.17"
- name: Test
run: cargo test --verbose --all-features
- name: Setup iptables for the timeout test
Expand Down
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,14 @@
[Rust Blog]: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html

Bitcoin Electrum client library. Supports plaintext, TLS and Onion servers.

## Minimum Supported Rust Version (MSRV)

This library should compile with any combination of features with Rust 1.63.0.

To build with the MSRV you will need to pin dependencies as follows:

```shell
cargo update -p rustls --precise "0.23.17"
```

0 comments on commit f00b999

Please sign in to comment.