Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order_by option to Query.changes/2 #114

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

wkirschbaum
Copy link
Contributor

Solves #113

I struggled to set up more than one change record for the test, so need some help there.

Copy link
Collaborator

@maltoe maltoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkirschbaum

Thank you!

Could you add a line to top of the CHANGELOG.md as well?

## Unreleased

### Added

* .... (@wkirschbaum)

lib/carbonite/query.ex Outdated Show resolved Hide resolved
test/carbonite/query_test.exs Show resolved Hide resolved
Co-authored-by: Malte Rohde <maltoe@posteo.de>
@wkirschbaum
Copy link
Contributor Author

@maltoe thanks for the feedback and help. I updated the commit with the suggested changes I believe. Feel free to edit the commit if there is something small not to your liking.

@maltoe maltoe merged commit 144946d into bitcrowd:main Aug 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants