[Push] Upon notification, only enqueue sync for the respective service type #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnyminerZ
added
enhancement
|
I have still not tried it, the emulator is not working on my laptop for some reason (not enough RAM I think). I will test this ASAP. |
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
force-pushed
the
1152-push-upon-notification-only-enqueue-sync-for-the-respective-service-type
branch
from
d5be215 to
f3d8911
Compare
|
Since #1177, the sync workers are per @ArnyminerZ Can you please adapt the PR accordingly? It should be much shorter now. |
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
reviewed
Dec 27, 2024
app/src/main/kotlin/at/bitfire/davdroid/push/UnifiedPushReceiver.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
reviewed
Dec 27, 2024
app/src/main/kotlin/at/bitfire/davdroid/push/UnifiedPushReceiver.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Looks good! Just two style comments:
- In this project curly braces are usually not used for one-line statements. I know that usage of then-blocks with/out curly braces is a matter of dispute, but I generally prefer the variant without extra curly braces because it makes it more hard to read for me personally. Of course there may be some special cases where curly braces are useful to make clear what's going on even if not strictly necessary (nested
ifs etc). - Instead of
add, we also can use+=. Makes it a bit shorter.
…-sync-for-the-respective-service-type
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
approved these changes
Dec 29, 2024
rfc2822
deleted the
1152-push-upon-notification-only-enqueue-sync-for-the-respective-service-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When receiving a push notification, do not enqueue sync for all authorities, schedule only for the collection type's authority.
Short description
After receiving a push notification, after the collection and service are loaded, the collection type is checked. Those authorities are scheduled depending on the type:
TYPE_ADDRESSBOOKat.bitfire.davdroid.addressbooks(R.string.address_books_authority)TYPE_CALENDARCalendarContract.AUTHORITYTYPE_WEBCALCalendarContract.AUTHORITYAlso, if the collection supports
VJOURNALorVTODO, a sync is enqueued for the current tasks provider, if any.If the type received is unknown or invalid, no sync is scheduled. We could change this behavior to sync everything, whatever you think suits best.
Checklist