-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync on collection update #1240
Open
sunkup
wants to merge
6
commits into
main-ose
Choose a base branch
from
851-force-read-only-setting-not-effective-immediately
base: main-ose
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync on collection update #1240
sunkup
wants to merge
6
commits into
main-ose
from
851-force-read-only-setting-not-effective-immediately
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 14, 2025
rfc2822
reviewed
Jan 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this behaves when the services are refreshed. Doesn't it enqueue a lot of syncs during service detection (whenever a collection is updated)?
My ideas (may or may not make sense):
- A delay of a few seconds between the collection change and the sync (like for the push registration) could at least reduce the number of synchronizations during service detection.
- Or maybe pause it somehow?
- Maybe separate callbacks for the actions we want to observe (update read-only, update sync flag)? Has advantages and disadvantages.
app/src/main/kotlin/at/bitfire/davdroid/sync/worker/SyncWorkerManager.kt
Outdated
Show resolved
Hide resolved
sunkup
force-pushed
the
851-force-read-only-setting-not-effective-immediately
branch
2 times, most recently
from
January 21, 2025 09:24
945029e
to
7f58df8
Compare
sunkup
force-pushed
the
851-force-read-only-setting-not-effective-immediately
branch
from
January 21, 2025 09:45
f9a0940
to
7d4bca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Nice to have for:
Short description
SyncWorkerManager
listen to any collection changes and use the account passed along toChecklist