Skip to content

Commit

Permalink
Merge pull request #44 from bithost-gmbh/prepare-release-1-3-0
Browse files Browse the repository at this point in the history
Prepare release 1.3.0
  • Loading branch information
macjohnny authored Jul 12, 2018
2 parents fc6ee7f + 51be0e0 commit b625f68
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 4 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## 1.3.0
* Enhancement: allow customization of the clear icon [#41](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/41)

Thanks to @OvidijusStukas

* Enhancement: Add note about possible workaround for search input being displayed
outside of the visible viewport in some cases [#1](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/1)

Thanks to @maxencefrenette

## 1.2.4
* Enhancement: ensure forward compatibility independent of markup changes [#38](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/38)
* Enhancement: fix warnings in tests, improve example
Expand Down
20 changes: 18 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,31 @@ Furthermore, it provides the following inputs:
@Input() clearSearchInput = false;
```

#### Customize clear icon
In order to customize the search icon, add the `ngxMatSelectSearchClear` to your custom clear item (a `mat-icon` or any other element) and place it inside the `ngx-mat-select-search` component:
```html
<ngx-mat-select-search>
<mat-icon ngxMatSelectSearchClear>delete</mat-icon>
</ngx-mat-select-search>
```

## Known Problems / Solutions
* The search input is placed outside of the visible screen if the select element is at the top of the screen
(in the stackblitz example, remove the header
or add some content above the select and scroll the select to the top edge). [#1](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/1)

Workaround: use the disableOptionCentering option on the `<mat-select>`
[https://material.angular.io/components/select/api](https://material.angular.io/components/select/api)


## Development

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 1.7.1.

## Contributions
### Contributions
Contributions are welcome, please open an issue and preferrably file a pull request.

## Development server
### Development server

Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ngx-mat-select-search",
"description": "Library that provides an angular component providing an input field for searching / filtering MatSelect options of the Angular Material library.",
"version": "1.2.4",
"version": "1.3.0",
"license": "MIT",
"scripts": {
"ng": "ng",
Expand Down

0 comments on commit b625f68

Please sign in to comment.