-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/harbor] Fix REGISTRY_HTTP_SECRET creation when not using an existing secret #31013
Open
uivraeus
wants to merge
5
commits into
bitnami:main
Choose a base branch
from
uivraeus:fix/registry-http-secret-creation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that temporary variable defaults to empty string if there is not existing value for the secret key. This follows the implementation strategy applied in "core-secret-envvars.yaml" Signed-off-by: Ulf Ivraeus <ulf.ivraeus@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
Execute verification workflow for these changes
in-progress
labels
Dec 12, 2024
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
bitnami-bot
added
stale
15 days without activity
and removed
stale
15 days without activity
labels
Jan 2, 2025
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ensure that
REGISTRY_HTTP_SECRET
can be assigned when there is no existing Secret with a value for it.The fix is to let the temporary variable used for a potentially existing secret value default to an empty string. This follows the implementation strategy applied in "core-secret-envvars.yaml"
Benefits
Possible to control the value of
REGISTRY_HTTP_SECRET
Possible drawbacks
None
Applicable issues
Additional information
None
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm