Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] Upgrade postgres to version 17.2.0 #31159

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lusu007
Copy link
Contributor

@lusu007 lusu007 commented Dec 25, 2024

Description of the change

The commit 017c8c3 should update the postgres version to version 17.x. But it did not. The patch release after this commit upgrades Postgres to version 14 and not 17. This is also referenced in the README.md of the chart. To solve this issue, this commit really updates Postgres to version 17.2.

Benefits

Use newest Postgres version.

Possible drawbacks

Manual upgrade of Postgres is needed (again).

Applicable issues

None

Additional information

I have Harbor with PostgreSQL version 17.2 in production without any issues.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

The commit 017c8c3 should update the postgres version to version 17.x. But it did not. The patch release after this commit upgrades Postgres to version 14 and not 17. This is also referenced in the README.md of the chart. To solve this issue, this commit really updates Postgres to version 17.2.

Signed-off-by: Lukas Jost <lukas.jost@outlook.com>
@github-actions github-actions bot added harbor triage Triage is needed labels Dec 25, 2024
@github-actions github-actions bot requested a review from carrodher December 25, 2024 14:00
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher
Copy link
Member

According to the "Harbor Components" section from https://goharbor.io/docs/2.12.0/install-config/, the default/recommended PostgreSQL major version is 14, that's the reason why we're overriding the container image of the PostgreSQL subchart.
By default, the latest PostgreSQL subchart bundles PostgreSQL 17, but we need to override its version in the values.yaml to match the version recommended by the upstream maintainers.

@lusu007
Copy link
Contributor Author

lusu007 commented Dec 26, 2024

Thank you for your response! I appreciate you taking the time to provide clarification. I want to point out a few additional considerations regarding the PostgreSQL version and its relationship with Harbor.

The documentation you referenced mentions PostgreSQL 14 as the default version. However, there is no explicit recommendation that PostgreSQL 14 is the only supported version or the version users should always use. It appears to be more of a default choice that hasn’t been updated yet rather than an official recommendation.

Furthermore, the Harbor maintainers have supported users upgrading to newer PostgreSQL versions, as seen in discussions like Harbor Issue #20800. This suggests that newer versions (e.g., PostgreSQL 15 or even 17) are compatible or becoming so, rather than strictly adhering to PostgreSQL 14.

As noted, there has already been progress toward upgrading PostgreSQL versions in certain Harbor-related contexts, like Harbor Issue #19512, where efforts were made to move to PostgreSQL 15.

Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
@carrodher
Copy link
Member

Since Harbor is a product maintained by VMware, let me try to ping the Harbor maintainers internally to clarify what the default version is and what the plans are to support more recent versions in the short term.

bitnami-bot and others added 3 commits January 2, 2025 09:10
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Lukas Jost <lukas.jost@outlook.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harbor triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants