Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/clickhouse] Fix: bind ipv6 and ipv4 by default #31168

Closed
wants to merge 1 commit into from

Conversation

JulesdeCube
Copy link

Motivation

The current clickhouse helm chart don't support ipv6 only cluster.

Context

By default clickhouse bind localhost on ipv4 and ipv6 (see https://github.com/ClickHouse/ClickHouse/blob/master/programs/server/config.xml#L253).

The bitnami container override this behaviors and bind to any ipv4 by passing -- --listen_host=0.0.0.0 to clickhouse-server via the CMD (see https://github.com/bitnami/containers/blob/main/bitnami/clickhouse/24/debian-12/Dockerfile#L60).
this is easily override to listen on ivp6 by changing the container command to /opt/bitnami/scripts/clickhouse/run.sh -- --listen_host="::".

The helm chart use an hard coded script as it's entry with no possibility to pass/override argument to clickhouse-server. (see https://github.com/bitnami/charts/blob/main/bitnami/clickhouse/templates/scripts-configmap.yaml)

Description of the change

this PR:

  • remove the default clickhouse-server arguments.
  • allow to specify clickhouse-server arguments.
  • use the defaultConfigurationOverrides to listen on ipv4 and ipv6

Benefits

Add Support for ipv6 only cluster

Possible drawbacks

It's harder to change listen_host in the xml config file.

Applicable issues

related with OneUptime/oneuptime#1348

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher
Copy link
Member

Thanks for your contribution! Please note that you need to give writable access to @bitnami-bot in your fork so that the README, CHANGELOG, and CRDs are updated; otherwise, that action will fail:

remote: Permission to diabolocom/bitnami-charts.git denied to bitnami-bot.
fatal: unable to access 'https://github.com/diabolocom/bitnami-charts/': The requested URL returned error: 403

@JulesdeCube
Copy link
Author

Thanks for your contribution! Please note that you need to give writable access to @bitnami-bot in your fork so that the README, CHANGELOG, and CRDs are updated; otherwise, that action will fail:

remote: Permission to diabolocom/bitnami-charts.git denied to bitnami-bot.
fatal: unable to access 'https://github.com/diabolocom/bitnami-charts/': The requested URL returned error: 403

Hello,

I don't have access to enabling repository maintainer edition as It's an organization own repository.
And I try to make the bot maintainer (write access) on the repository but as it's a "user" it is still in pending state.

Did you have any other solution or did I need to fork this repository under my personal namespace and open a new PR ?

@carrodher
Copy link
Member

Unfortunately there is not any other option, @bitnami-bot need to update the branch from where the PR is created 😞

Modify `defaultConfigurationOverrides` to listen on ipv4 and ipv6 and
replace the default launch args of the `setup.sh` to accept args

Signed-off-by: Jules Lefebvre <jules.lefebvre@diabolocom.com>
@JulesdeCube
Copy link
Author

Close in favor of #31200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants