Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP71 - Change Request: Incorporate core changes necessary for BSIP-0076 to allow a threshhold price #224

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sschiessl-bcp
Copy link
Collaborator

@sschiessl-bcp sschiessl-bcp commented Sep 30, 2019

To accomodate #221 from core side in #179

Premise is that independent how you stand towards the ongoing feed price alterations, we need to allow witnesses to feed outside market price while still being able to affect margin calls and force settlements in the desired way.

@ryanRfox ryanRfox changed the title Incorporate core changes necessary for BSIP-0076 to allow a threshhold price BSIP71 - Change Request: Incorporate core changes necessary for BSIP-0076 to allow a threshhold price Sep 30, 2019
@abitmore
Copy link
Member

Updated wording. Now looks good to me.

@ryanRfox
Copy link
Contributor

Yes. Looks good to me. Thank you @sschiessl-bcp for updating this BSIP. I've requested @pmconrad or @MichelSantos to provide the final review as they contributed on the previously merged BSIP71.

@pmconrad
Copy link
Contributor

pmconrad commented Oct 1, 2019

I will not support such a protocol change, not even with a review.

@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Oct 2, 2019

The realization of this BSIP allows debt holders to massively increase voting power, artifically in my opinion. This might hinder progress in the future, or give incentive to drive progress into one single direction (to accomodate margin position holders).

Thinking more about this I think it is a necessary, simple and justifiable addition to this BSIP is that the voting power of a margin position is reduced, and only the voting power of the excess BTS count towards the margin position holders. Then we have one question to discuss: Should we do anything with the "lost voting power", or simply have it lost?

Example: Margin position with CR 1.6. The voting power of this margin position is reduced by a BTS amount equivalent of CR 1.

Thoughts?

@abitmore
Copy link
Member

abitmore commented Oct 2, 2019

IMHO the logic around voting (or weight) is in the scope of BSIP24 and #83, but not this BSIP.

@thul3
Copy link

thul3 commented Oct 2, 2019

This BSIP allows EVERYONE to increase their voting power not just existing debt holders

@abitmore
Copy link
Member

abitmore commented Oct 2, 2019

It's essentially a negotiation between smartcoin holders and smartcoin creators (aka borrowers or debt position holders).

Let's score the options on the desk. Assuming the option that gives the smartcoin holders the most benefits has a score of 1, the option that gives the smartcoin creators the most benefits has a score of 5.

Here are my scores for the options:

  • the old GS rule, score 3.
  • the already-merged draft of BSIP71 favors smartcoin holders over creators, but still shows some merit for the creators e.g. the "fill the least collateralized call order first" rule, score 2;
  • in the discussion when drafting BSIP71 (BSIP71: Add "Prevent Global Settlement" Flag for Smartcoin #193), some people came up with ideas that favors smartcoin holder more (IMHO), e.g. "always settle at feed price" and "filling as much margin-called debt as possible", score 1;
  • the "price threshold" rule discussed in this issue and BSIP76 favors smartcoin creators over smartcoin holders under certain circumstances, score 4.

People are taking sides.

@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Oct 2, 2019

This BSIP allows EVERYONE to increase their voting power not just existing debt holders

That is correct. It assumes that all BTS holders are risk lovers and want to participate like that.

@sschiessl-bcp
Copy link
Collaborator Author

IMHO the logic around voting (or weight) is in the scope of BSIP24 and #83, but not this BSIP.

Also correct. This BSIP allows debt holders to margin to the max risk-free, while significantly and overwhelmingly increasing their voting power. That is why I see it relevant in here.

@ryanRfox
Copy link
Contributor

ryanRfox commented Oct 2, 2019

What do we want to do with BSIP71 at this time?

  • Vote on the merged BSIP71 draft
  • Continue discussions on this Change Request

@liondani
Copy link

liondani commented Oct 2, 2019

The realization of this BSIP allows debt holders to massively increase voting power, artifically in my opinion. This might hinder progress in the future, or give incentive to drive progress into one single direction (to accomodate margin position holders).

Thinking more about this I think it is a necessary, simple and justifiable addition to this BSIP is that the voting power of a margin position is reduced, and only the voting power of the excess BTS count towards the margin position holders. Then we have one question to discuss: Should we do anything with the "lost voting power", or simply have it lost?

Example: Margin position with CR 1.6. The voting power of this margin position is reduced by a BTS amount equivalent of CR 1.

Thoughts?

What if we give the option to bitASSETs holders to give the "lost" voting power (or even generate more voting power!) back to margin position holders by activating a yearly interest rate of 1% (or more) to bitASSETs owners that get's paid straight from the margin position holders pockets + partially from a worker if absolutely necessary?

bsip-0071.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MichelSantos MichelSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three risks should be added

First, the abstract states that "this BSIP allows the asset owner to define an optional threshold price to prevent external market manipulation." The obvious risk is that the asset owner may actually use any justification for setting the threshold.

Second, the holder's fundamental ability to redeem the asset at a market price through force settlement is potentially being changed after the fact by the asset holder if the new threshold price is set.

Third, this effectively transforms the asset issuer into a currency board that can effectively suspend redemption claims. This may potentially be a conflict of interest if the issuer is also borrowing the asset into existence.

@MichelSantos
Copy link
Contributor

@sschiessl-bcp Please also change "%div;" to "÷"

@sschiessl-bcp
Copy link
Collaborator Author

i adressed all comments.

  • now two flags, one for threshold one for prevent GS
  • added voting reduction

bsip-0071.md Outdated Show resolved Hide resolved
MichelSantos
MichelSantos previously approved these changes Oct 7, 2019
@sschiessl-bcp
Copy link
Collaborator Author

I'd like to hear some more opinions.

Option a)
Put it up in one BSIP

Option b)
Put threshold as one, and margin position correction as another. Both would need to be available for voting at the same time.

@clockworkgr
Copy link
Member

If given the choice, I don't believe that voting power correction for margin positions will ever make it.

I believe it won't pass the voting, so why we waste time/efforts/funds including it in the BSIP? Having it in the BSIP means other features in the BSIP won't pass as well.

That's the whole point. Including it in the BSIP forces the affected parties to compromise.

@abitmore
Copy link
Member

abitmore commented Oct 8, 2019

I'd like to hear some more opinions.

Option a)
Put it up in one BSIP

Option b)
Put threshold as one, and margin position correction as another. Both would need to be available for voting at the same time.

You're misleading. The main point is not whether to put them into one BSIP, but whether to have the voting power change in the BSIP.

Including it in the BSIP forces the affected parties to compromise.

Why to force?

@pmconrad pmconrad removed their request for review October 8, 2019 12:24
@clockworkgr
Copy link
Member

I'd like to hear some more opinions.
Option a)
Put it up in one BSIP
Option b)
Put threshold as one, and margin position correction as another. Both would need to be available for voting at the same time.

You're misleading. The main point is not whether to put them into one BSIP, but whether to have the voting power change in the BSIP.

Including it in the BSIP forces the affected parties to compromise.

Why to force?

because as you said...it would never get voted on its own.

When its in one BSIP it's give and take

@Yamtt
Copy link

Yamtt commented Oct 8, 2019

从本质上讲,这是Smartcoin持有者与Smartcoin创造者(又名借款人或债务头寸持有者)之间的谈判。

让我们在桌子上打分。假定为smartcoin持有者带来最大收益1的期权得分为,则为smartcoin创造者带来最大收益的期权得分为5

这是我的选项得分:

  • 旧的GS规则,得分3
  • 已经合并的BSIP71草案更偏向于Smartcoin持有者,而不是创建者,但仍对创建者显示出一些好处,例如“先填写最低抵押呼叫顺序”规则,得分2
  • 在讨论中,在起草BSIP71(#193)时,有人提出了更偏爱智能币持有人(IMHO)的想法,例如“总是以进料价格结算”和“尽可能多地填补所谓的保证金债务” 1
  • 在某些情况下,本期讨论的“价格门槛”规则和BSIP76会优先考虑smartcoin的创建者而不是smartcoin的持有者4

人们站在一边。

creator

@bitProfessor
Copy link

应该增加三个风险

首先,摘要指出:“该BSIP允许资产所有者定义可选的阈值价格,以防止外部市场操纵。” 明显的风险是资产所有者可能实际上会使用任何理由来设置阈值。

其次,如果设定了新的阈值价格,资产持有人_在事后_可能会改变持有人通过强制结算以市场价格赎回资产的基本能力。

第三,这有效地将资产发行人转变为可以有效暂停赎回要求的货币发行局。如果发行人也在借入资产,则可能存在利益冲突。

Yes

Copy link
Contributor

@bitcrab bitcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to create a new BSIP for this feature rather than adding it to BSIP71. Some voters may want the GSP feature but not this one, some others may want this but not the GSP feature.

agree, actually I feel maybe it's too early to add the feed price threshold feature to core code level, I believe we need the feed price threshold feature but we still need to see the impact it bring to the smartcoin system, so it's not bad to let it stay at witness level some longer period, and push it to core code level when we learn enough about it and reach stronger consensus, as GS protection has experienced.

#### Adjustment to voting power

The voting power for BTS backed SmartCoins added to the owner of a margin position is reduced. Only the exccess collateral counts as voting power. Example: If a position has CR 1.8, the voting power from this position only counts the BTS that represent the excess of 0.8. Reasoning for this is given in the section Discussion / Voting power.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally disagree with the adjustment to voting power, voting power is inside BTS, one should own the voting power of the BTS in his account, either his account is debt free or not, debt just means he would like to bear the relevant risk, no others.

Copy link

@tonyniu352 tonyniu352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core development team's main responsibility is to make sure that the system code runs safely and reliably,and add new feature into system which shall has no negative impact on the original business logic or function . however,for a system like bts running for many years, voting rights adjustments obviously beyond the duty of the development team. The development team is not authorized to modify voting power or discuss how to change such power of bts holder.

@tonyniu352
Copy link

it is a important reminder for everyone on the core team that you are not authorized to infringe the voting rights of the bts holder. voting power is also property arrribute attached to bts coin, that is,you are not allowed to infringe the property of bts holders. if the voting right adjustment is approved, the call for a vote of no-confidence in the core team is possible.

@clockworkgr
Copy link
Member

"which shall has no negative impact on the original business logic or function"

So no changing the original business logic?

Stop making silly arguments only when it suits you

@bitProfessor
Copy link

After price recovery, I no longer support gs, bsip76. without bitcny, I couldn't find any reason to support it.

@pmconrad
Copy link
Contributor

pmconrad commented Oct 9, 2019

The development team is not authorized to modify voting power

We developers know that. We do not change consensus without following proper procedures, i. e. creating a BSIP and have it approved by shareholders. Unlike others.

or discuss how to change such power of bts holder.

We are also shareholders, and as such we are of course authorized to discuss changes.

you are not allowed to infringe the property of bts holders

You guys had no problems with infringing the property of bitCNY/bitUSD holders when you approved BSIP-76, and now you are complaining that others are discussing the same?

@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Oct 9, 2019

Related or not related to this topic, this was posted in Telegram just now.

cn-vote, [09.10.19 12:39]
I want to remind the current core development team. Cn-vote has always supported the core development team, please do not live up to everyone's expectations. The core development team should not forget what they are and what they should do. Do your own job, because there are already many excellent and cheaper teams who have repeatedly sought to compete for the core team.

cn-vote, [09.10.19 12:44]
BM left, and the bitshares have been running steadily for so many years. Therefore, no one is indispensable. Don't forget who you are and what you should do. Do your job well and everyone will always support you. Otherwise, there will be more suitable teams and people. Thank you all.
A job like this high salary and not so busy can be difficult to find. Many excellent teams have been coveted for a long time.

Like Peter said, this is a discussion thread. Any and all changes will need to pass voting first.

bsip-0071.md Show resolved Hide resolved
bsip-0071.md Show resolved Hide resolved

- traders could no longer borrow bitUSD;
- the price of bitUSD dropped below USD because of insufficient collateral; and,
- it will take a long time for bitUSD to be revived.

The community has had extensive discussions about how to handle the bad debt in a better way in the future. However an easy way, [BSIP58](https://github.com/bitshares/bsips/blob/master/bsip-0058.md), has been implemented for smartcoins like bitCNY and bitUSD; it has worked successfully to prevent GS from happening with no other obvious impact. However, BSIP58 has some issues - it is suspected of market manipulation and it risks witnesses independence. Moving forward, this BSIP will be built based on BSIP58 and eliminate all its disadvantages.
The community has had extensive discussions about how to handle the bad debt in a better way in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't sound like a bad consequence of global settlement.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevance?

bsip-0071.md Show resolved Hide resolved
@@ -39,9 +60,12 @@ We now have several choices on handling bad debt:

We need to do a deep review on bad debt before evaluating above solutions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When can we expect this deep review on bad debt? Why can't we work on improving the price feed scripts in parallel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know. Certainly we can, care to join?


At this moment, the system should accept the fact that the smartcoin will possibly devalue, find ways to minimize the impact to different parties in the market and the time to revive.
At this moment, the system should accept the fact that the smartcoin will possibly devalue,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just a possibility, but now a fact that the CNY & USD assets have been devalued by BSIP 76.

bsip-0071.md Outdated
if flag "Prevent Global Settlement" is enabled
settlement price = max(FP_M * (1 - settlement_offset), P_gs)
call execution price = max(FP_M * (1 + MSSR), P_gs)
if flag "Prevent Global Settlement and External Attacks" is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add flags "Prevent Global Settlement"
flag "Prevent Global Settlement and External Attacks"

Which is the final name for the flag?

bsip-0071.md Outdated Show resolved Hide resolved
bsip-0071.md Show resolved Hide resolved
bsip-0071.md Show resolved Hide resolved
Variant B would have let bad debt positions matched at their own collateral ratio while matching other margin calls as before at FP<sub>M</sub> &times; MSSR, hoping to improve the overall collateralization. This also means that debt positions with better collateral ratio would have been preferred over bad debt, meaning that bad debt positions will remain sitting on the market for a longer time.
- If the Threshhold is set, conflict of interest exists if the asset owner is also borrowing the asset into existence

- If the Threshhold price is set, margin positions creators essentially have a call price limit that they can set in order to avoid ever being margin called. This means the position carries no risk for the margin position holder anymore, which can be seen as incentive to borrow as much as possible without considering the consequences. This is the reason to adjust the voting weight of a BitAsset position

# Summary for Shareholders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impact on smartcoin, debt & bts holders?

@sschiessl-bcp
Copy link
Collaborator Author

Fixed the calculation wording when flags are set, so at least the idea is correctly presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.