Revive old migrations PR #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
188f126
|
| Status: | 🚫 Build failed. |
|
No New Or Fixed Issues Found |
Hinton
commented
Aug 1, 2023
| [T-SQL Code Style][code-style-sql] for more details. But the most important aspect is ensuring the | ||
| script can be re-run on the database multiple times without producing any errors or data loss. | ||
|
|
||
| ### Backwards Compatible |
There was a problem hiding this comment.
We should add a section better describing when non backwards compatible migrations needs to be used.
Hinton
commented
Aug 1, 2023
Comment on lines
+76
to
+79
| We now need to write a script that migrates any data from the old location to the new locations. | ||
| This script should ideally be written in a way that supports batching, i.e. execute for X number of | ||
| rows at a time. This helps avoiding locking the database. When running the scripts against the | ||
| server please keep running it until it affects `0 rows`. |
There was a problem hiding this comment.
Need to decide if data migrations are destructive or non destructive. I.e. duplicate the data for a while.
…ributing-docs into ps/migrations # Conflicts: # docs/contributing/database-migrations/index.md
…ps/migrations * 'master' of github.com:bitwarden/contributing-docs: (37 commits) chore(deps): update dependency cspell to v7.3.7 (#206) [PM-4161] Fix build command on README.md (#207) Fixed typo in csharp.md (#180) Update our EDD process documentation (#166) chore(deps): update actions/checkout action to v4.1.0 (#204) chore(deps): lock file maintenance (#205) fix(deps): update npm minor to v2.4.3 (#203) use dash when running self-hosted dotnet profile (#202) chore(deps): update actions/checkout action to v4 (#191) chore(deps): lock file maintenance (#201) chore(deps): update npm minor (#195) fix(deps): update dependency docusaurus-lunr-search to v3 (#200) setup_secrets: Pass `-clear` as switch (#194) Update KeyConnector docs for ARM Macs (#171) Lock file maintenance (#193) Update dependency cspell to v7.3.5 (#192) Update dependency ubuntu to v22 (#174) Update gh minor (#181) Feature flag documentation updates and mentions about new local override capabilities (#187) Update npm minor (#188) ... # Conflicts: # custom-words.txt # docs/contributing/database-migrations/edd.mdx # docs/contributing/database-migrations/index.md
joseph-flinn
previously approved these changes
Mar 11, 2024
…/migrations # Conflicts: # docs/getting-started/server/database/mssql/index.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Expand the migration page and break it up into two focusing on the different database engines.