Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about linux biometrics #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Sep 12, 2024

🎟️ Tracking

📔 Objective

Linux is now supported via Polkit.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner September 12, 2024 11:00
Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05c71a6
Status: ✅  Deploy successful!
Preview URL: https://f7352eca.contributing-docs.pages.dev
Branch Preview URL: https://km---linux-biometrics.contributing-docs.pages.dev

View logs

Copy link

Logo
Checkmarx One – Scan Summary & Detailse38b2e0a-be3b-4b73-a536-611ce827a2b6

No New Or Fixed Issues Found

@@ -21,12 +21,12 @@ _Supported:_
- Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download)
- Mac Apple Store downloaded Mac App
- Windows Desktop Apps via Windows Hello
- Linux Desktop via Polkit
Copy link
Contributor

@djsmith85 djsmith85 Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Tiny nit as it's part of all the supported ones above

Suggested change
- Linux Desktop via Polkit
- Linux Desktop Apps via Polkit

@@ -21,12 +21,12 @@ _Supported:_
- Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download)
- Mac Apple Store downloaded Mac App
- Windows Desktop Apps via Windows Hello
- Linux Desktop via Polkit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The linter is complaining as it doesn't know the word Polkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants