Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readOnlyConnectionString #454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

📔 Objective

The readOnlyConnectionString isn't documented anywhere publicly, and is relevant when developing locally for self-hosting.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner October 14, 2024 14:54
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68e8296
Status:🚫  Build failed.

View logs

Copy link

github-actions bot commented Oct 14, 2024

Logo
Checkmarx One – Scan Summary & Details6359f6c3-7dc4-445f-9909-0a443b47f7ee

No New Or Fixed Issues Found

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used with Dapper and therefore MSSQL here so you'd want this on those docs, not EF.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants