Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about desktop-browser integration #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-14402

๐Ÿ“” Objective

With the recent IPC changes and developer experience improvements around biometrics, the documentation should be updated to match.

  • The IPC proxy is not baked in the application anymore, but is a separate binary that is included with the application.
  • MacOS in dev mode can use IPC without requiring an App Store build or disabling Gatekeeper now, so I've removed the warning.
  • The desktop app can autodetect the installed developer-mode browser extensions and add them to the manifests. Rewrote the instructions around that part and moved the Build the Desktop app section before the Add the Extension ID for Native Messaging section, which now should only be done manually as a last resort if the autodetection doesn't work.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia requested a review from a team as a code owner November 1, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant