Add community PR process documentation #471
Merged
+66
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
539ba43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac6fc582.contributing-docs.pages.dev |
| Branch Preview URL: | https://add-community-pr-process.contributing-docs.pages.dev |
|
No New Or Fixed Issues Found |
trmartin4
changed the title
withinfocus
previously approved these changes
Nov 12, 2024
| ## Product assessment | ||
|
|
||
| When your community contribution is received, the first step is for our Product team to evaluate | ||
| whether the change aligns with the vision for the Bitwarden product. This is more relevant for |
There was a problem hiding this comment.
Suggested change
| whether the change aligns with the vision for the Bitwarden product. This is more relevant for | |
| whether the change aligns with the vision for the Bitwarden products. This is more relevant for |
There was a problem hiding this comment.
Addressed with 539ba43 (#471).
| ## Engineering assessment | ||
|
|
||
| The Engineering team(s) responsible for the change depend largely on what code was changed. We use | ||
| Github code owners to manage the areas in our repositories owned by each team, and the responsible |
There was a problem hiding this comment.
Suggested change
| Github code owners to manage the areas in our repositories owned by each team, and the responsible | |
| GitHub code owners to manage the areas in our repositories owned by each team, and the responsible |
There was a problem hiding this comment.
Addressed with 539ba43 (#471)
|
|
||
| ::: | ||
|
|
||
| The responsible Engineering teams will review the change and ensure that there are no concerns |
There was a problem hiding this comment.
Suggested change
| The responsible Engineering teams will review the change and ensure that there are no concerns | |
| The responsible Engineering team(s) will review the change and ensure that there are no concerns |
There was a problem hiding this comment.
Addressed with 539ba43 (#471).
| ::: | ||
|
|
||
| The responsible Engineering teams will review the change and ensure that there are no concerns | ||
| around how the change was implemented. This is generally more applicable for larger sets of changes, |
There was a problem hiding this comment.
Suggested change
| around how the change was implemented. This is generally more applicable for larger sets of changes, | |
| around how the change was implemented; this is generally more applicable for larger sets of changes, |
There was a problem hiding this comment.
Addressed with 539ba43 (#471).
withinfocus
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
Provide clarity for our community contributors around what our internal processes are for managing contributions. This is intended to be high-level enough that it doesn't have to change based on individual teams' implementation details around how they manage community PRs, but instead give contributors insight into what the communication points are likely to be when they submit a PR and help them understand why some PRs might take longer than others.
Once deployed, I intend to change the auto-generated message on all community PRs to include a link to this page,.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes