-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2224] [deps]: Update open to v10 #456
Conversation
Internal tracking:
|
New Issues
Fixed Issues
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in cliPlatformUtilsService, however this doesn't seem to be used in directory connector. I'm OK with removing it - in fact, this is not a bad way to work our way through unused dependencies.
It would also be good to delete the dead code so that there's not code in the project that is intentionally missing dependencies. However, that might be a more comprehensive effort as imports seem to cascade through jslib quite easily.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 58 58
Lines 2542 2542
Branches 462 462
=====================================
Misses 2542 2542 ☔ View full report in Codecov by Sentry. |
This is discussed a bit above, but to be clear: I replaced the function body this package was referenced in with a not implemented error, and removed its references in jslib. They were for opening SSO login screens from a CLI, which is not supported in DC. |
This PR contains the following updates:
8.4.2
->10.0.3
Release Notes
sindresorhus/open (open)
v10.0.3
Compare Source
target
option on macOS (#332)b597dec
v10.0.2
Compare Source
798cd93
v10.0.1
Compare Source
8e69be4
v10.0.0
Compare Source
Breaking
5628dc8
v9.1.0
Compare Source
46adf0b
v9.0.0
Compare Source
Breaking
7f5995e
open.openApp
is now a named import:import {openApp} from 'open'
open.apps
is now a named import:import {apps} from 'open'
Improvements
3b79981
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.
AC-2224