[PM-13007] Fix Active Directory externalId parsing

[eliykat]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13007

📔 Objective

Fix the following bug from #641. When performing multiple syncs with an Active Directory server, QA received the following error:

[Error] An item with the same key has already been added. Key: ----

It was also noted that:

Per the payload BWDC sent over. All of the groups + users have an externalId of ----

Active Directory uses the objectGUID attribute value as the exteranlId. It is sent as a buffer, but ldapts treats all attributes as strings unless told otherwise. This mismatch meant that our bufToGuid method was silently failing and returning only the dashes in the guid string without any alphanumeric characters. (code ref)

Fixed by telling ldapts to return this attribute value as a buffer. Per the docs: https://github.com/ldapts/ldapts?tab=readme-ov-file#return-buffer-for-specific-attribute .

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.50%. Comparing base (6915667) to head (b66d97e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #693      +/-   ##
========================================
+ Coverage   2.24%   8.50%   +6.26%     
========================================
  Files         60      60              
  Lines       2633    2634       +1     
  Branches     467     467              
========================================
+ Hits          59     224     +165     
+ Misses      2571    2392     -179     
- Partials       3      18      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – ecc9d9bc-6dbb-4d12-b179-bdf6774dd5b0

No New Or Fixed Issues Found