Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14836: Fix vault state on app re-entry from background #1149

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

ezimet-livefront
Copy link
Collaborator

@ezimet-livefront ezimet-livefront commented Nov 19, 2024

🎟️ Tracking

PM-14836

📔 Objective

This PR addresses an issue where the vault, when unlocked from the App Extension with the timeout set to "Never," does not show as unlocked in the app until it is quit and reopened. I added a new action to re-evaluate the vault's state when the app re-enters the foreground, ensuring the unlocked status is correctly reflected without needing to restart the app.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Logo
Checkmarx One – Scan Summary & Details182fefd8-7c9f-4c8f-ae6b-be686fe601f8

No New Or Fixed Issues Found

@ezimet-livefront ezimet-livefront changed the title PM-14836 PM-14836: Fix vault state on app re-entry from background Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (40d9387) to head (9066201).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   89.49%   89.50%           
=======================================
  Files         688      688           
  Lines       43509    43539   +30     
=======================================
+ Hits        38940    38970   +30     
  Misses       4569     4569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ezimet-livefront ezimet-livefront merged commit 8293f41 into main Nov 23, 2024
9 checks passed
@ezimet-livefront ezimet-livefront deleted the PM-14836/unlocked-vault-bug branch November 23, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants