generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15904] Implement Credential Exchange Import flow #1223
Open
fedemkr
wants to merge
10
commits into
main
Choose a base branch
from
PM-14800/impl-cxp-import-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,306
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BitwardenShared/Core/Platform/Services/ServiceContainer.swift # BitwardenShared/Core/Platform/Services/TestHelpers/ServiceContainer+Mocks.swift
fedemkr
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
December 19, 2024 20:42
No New Or Fixed Issues Found |
BitwardenShared/Core/Platform/Services/API/Extensions/AnyKey.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Tools/Repositories/ImportCiphersRepository.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Tools/Repositories/ImportCiphersRepositoryTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Tools/Repositories/ImportCiphersRepository.swift
Outdated
Show resolved
Hide resolved
…approach and fixed some warnings.
matt-livefront
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15904
📔 Objective
Implement Credential Exchange import flow.
This is part of PM-14800 to implement the new APIs for Credential Exchange on iOS 18.2. Also a continuation of #1198
This also updates the SDK revision to
02332b257970cde14e48a8708e12e722f4a236d9
so that it includes the Credential Exchange functions of the SDK necessary to import/export credentials.Environment Support
#if compiler(>=6.0.3)
to ensure that block of code is only compiled when in the proper version of the compiler/Xcode; this ensures Xcode 16.1 (currently in CI/CD) version to continue compiling the project.Feature enablement
alpha_update_cxp_infoplist.sh
needs to be run first to update theInfo.plist
files with the proper configuration. I've also added this onselect_variant.sh
with a compiler flagSUPPORTS_CXP
so we can trigger builds with this enabled from the CI/CD passing such flag.Make sure you have OS Settings -> Developer -> Credential Exchange enabled and (in simulator) also a Face ID enrolled and enabled.
Additionally, particularly for the import flow there is a feature flag called
cxp-import-mobile
that also needs to be enabled. Otherwise, the import flow will show an error when the Bitwarden app opens. If on DEBUG mode, you can also change it in the DEBUG view while seeing the error and retry the operation.📸 Screenshots
Import.Credential.Exchange.flow.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes