[PM-7886] Show either card number or security code and not both #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
mannequin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Enhancing security by implementing a feature to hide the CVV (Card Verification Value) when displaying the card number and vice versa. This enhancement aims to mitigate the risk of unauthorized access to sensitive financial information and aligns with industry best practices for safeguarding user data.
Code changes
src/Core/Pages/Vault/CipherDetailsPageViewModel.cs
Modified ToggleCardNumber and ToggleCardCode methods
Before you submit
dotnet format --verify-no-changes) (required)