Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercise/highcharts 10 #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Exercise/highcharts 10 #8

wants to merge 2 commits into from

Conversation

KamilKubik
Copy link
Collaborator

No description provided.

@KamilKubik KamilKubik changed the title Apply exercise 10 finished version Exercise/highcharts 10 Oct 13, 2022
hihajdus
hihajdus suggested changes Oct 27, 2022
View reviewed changes
Copy link

@hihajdus hihajdus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main parts working great 🙂👍
Some little changes to the chart look need to add to improve.

highcharts-api/highcharts/10-histogram-point-select/main.js Show resolved Hide resolved
highcharts-api/highcharts/10-histogram-point-select/main.js Outdated Show resolved Hide resolved
highcharts-api/highcharts/10-histogram-point-select/main.js Outdated
Comment on lines 13 to 18
yAxis: [{
title: { text: 'Values' }
}, {
title: { text: 'Values' },
opposite: true
}],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to reproduce the chart accordingly you need to change ranges of y-axis.
So that the axis on the left has a range from 0 to 12, on the right from 0 to 8.

Add the minimum and maximum of the axis, to adjust.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as your suggestion 😄

hihajdus
hihajdus approved these changes Oct 27, 2022
View reviewed changes
Copy link

@hihajdus hihajdus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hihajdus hihajdus hihajdus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KamilKubik @hihajdus