Fix: honor capability bits of legacy J-Link V5 probes #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Add support for older J-Link V5 adapters to BMDA.
OEM considers these "legacy" https://wiki.segger.com/J-Link_BASE_V5_or_lower , in fact everything pre-V11.
IMO these are still okay for raw sequences and "accelerated bit-banging" of conventional good old JTAG, fixed-direction bus transceivers included.
I tested this on V5.4 and V5.3 yellow "Kickstart" adapters from 2006 and now they at least work. Also tested on V8 (same AT91SAM7S64, more bus transceivers for bidirectional SWD), no regressions, both SWD & JTAG are accessible and working.
Code loosely follows similar checks from openocd+libjaylink, published UM08001 and aims to be a follow-up to #1548.
The firmware in question does not support 0xc7 "EMU_CMD_SELECT_IF" commands at all. I can remove irrelevant parts of in-code comments on request.
Your checklist for this pull request
make PROBE_HOST=native
) -- not applicablemake PROBE_HOST=hosted
)Closing issues
I would open an issue about this back in August, but instead I provide a suggested fix here.