Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: add build target feedback to summary #1735

Merged

Conversation

perigoso
Copy link
Contributor

@perigoso perigoso commented Jan 15, 2024

Add wether firmware and BMDA are being built to the summary output

Detailed description

This just adds a couple entries to meson configuration summary output, telling the user if it's configured to build firmware, and if it's configured to build BMDA, given that the following situations are possible:

  • building firmware and BMDA
  • building firmware but not BMDA
  • building BMDA but not firmware
    Some feedback as to which one we are in felt needed.

Your checklist for this pull request

Closing issues

Add wether firmware and BMDA are being built to the summary output
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and seems like a nice addition to the summary output - merging as we can see this works right from the CI builds.

@dragonmux dragonmux added this to the v2.0 release milestone Jan 16, 2024
@dragonmux dragonmux added Enhancement General project improvement Build system Build system labels Jan 16, 2024
@dragonmux dragonmux merged commit f93e4ab into blackmagic-debug:main Jan 16, 2024
17 checks passed
@perigoso perigoso deleted the feature/bmda-build-feedback branch January 16, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build system Build system Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants