Fix: Clang fall-through warnings #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
force-pushed
the
fix/clang-fallthrough-warnings
branch
3 times, most recently
from
38221cd to
0b4e24c
Compare
…to help ensure the right things happen
dragonmux
force-pushed
the
fix/clang-fallthrough-warnings
branch
from
0b4e24c to
8a753f1
Compare
amyspark
added a commit
to amyspark/blackmagic
that referenced
this pull request
Jan 26, 2024
… to standards compliant mode
amyspark
added a commit
to amyspark/blackmagic
that referenced
this pull request
Jan 26, 2024
… to standards compliant mode
amyspark
added a commit
to amyspark/blackmagic
that referenced
this pull request
Jan 27, 2024
… to standards compliant mode
amyspark
added a commit
to amyspark/blackmagic
that referenced
this pull request
Jan 27, 2024
… to standards compliant mode
dragonmux
pushed a commit
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR addresses the Clang warnings about switch-case fall-through caused by it not understanding the magic comment
/* fall through */. To do this we've introduced a new macro and definition logic to use the compiler attribute for the job.Tested on GCC 12, ARM GCC 12 and Clang 18. CI build items should be added in the future but as CI needs an overhaul post-Meson-PR we'll do that in a separate PR.
Your checklist for this pull request
Closing issues