Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required meson build #1937

Closed
wants to merge 1 commit into from
Closed

Conversation

CIPop
Copy link

@CIPop CIPop commented Sep 20, 2024

Detailed description

Documentation update to requirements. Fixes #1933 Ubuntu 22.04 compilation issue: "error: ‘O_CLOEXEC’ undeclared (first use in this function); did you mean ‘FD_CLOEXEC’?" caused by default meson APT install on Ubuntu 22.

Note: previous meson (1.0?) builds might work as well. I have only tested with latest today (1.5.1).

Your checklist for this pull request

Closing issues

Fixes #1933

Note: previous 1.0 builds might work as well. I have only tested with latest today (1.5.1).

Fixes blackmagic-debug#1933
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've a comment around the minimum version requirement being suggested here, and please update your commit message to follow the contribution guidelines (misc: or readme: suffix). Other than that though, this looks fine.

@@ -114,7 +114,7 @@ use the `/dev/tty.usbmodemXXX` device node involving how it operates under the h
When developing this project, the following tools are required:

* [git](https://git-scm.com)
* [meson](https://mesonbuild.com/Getting-meson.html) (version 0.61 or greater)
* [meson](https://mesonbuild.com/Getting-meson.html) (version 1.5.1 or greater)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had it confirmed by another contributor that v1.1.1 also works. The changelog suggests that it was fixed in 0.63. Given this, let's bump the Meson requirement here to just 0.63 and see if anyone else complains with at least that. Think saying 1.5.1 as it's the latest release is a little too strict.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that bumping the meson version requirement should be done in the main meson.build first, there it'll produce a warning even for those who won't look at the readme

@dragonmux dragonmux added this to the v2.0 release milestone Sep 20, 2024
@dragonmux dragonmux added Bug Confirmed bug Documentation Project documentation labels Sep 20, 2024
@dragonmux dragonmux mentioned this pull request Dec 16, 2024
6 tasks
@dragonmux
Copy link
Member

We've wound up folding a change similar to this into #2019 which overhauls the whole README.md - so closing this as superseded by that PR.

@dragonmux dragonmux closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Documentation Project documentation
Projects
None yet
3 participants