-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cortex-M: Temptative fix for watchpoints so they work on ARMv8-M cores (eg Cortex-M33) #2008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good and complements our own work on ARMv8-M debug on the fix branch fix/adi-structural-cleanup
. We'd love to get this merged for v2.0 so if you can take care of the small number of review notes (most are to do with nomenclature and we don't think will take that long to deal with as it's mostly just find-replace stuff), we'll get this merged ASAP.
Thank you for the comments, will update it as soon as i can |
3ea0c6a
to
26f59ca
Compare
I think i took all the comments into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks good to us. Please let us know once you've squashed the commits down (noting that there should not be a space between the suffix and its' :
, so cortexm:
not cortexm :
) and we'll get this merged.
Thank you for the contribution! Nicely done.
3623438
to
54db90c
Compare
Should be okay now |
54db90c
to
b547574
Compare
Detailed description
The DWT block is different on Arm V8m compared to older revisions. As a result the watchpoint(s) function are not working.
The patch adds a second path dealing with the ArmV8m .
Tested on cortex m33, check setup watch some_variable (such as xTickCount on freeRtos)
It was partially tested, i dont have other chip with that DWT block. Only test write watchpoints.
As far as i can tell, watchpoints are still working with older chips (cortex M4)
Your checklist for this pull request
Closing issues