-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nRF54L #2009
Add support for nRF54L #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already had a bit of a chat on Discord about the adi.c and adiv5.c changes and how to evolve those, so this review is purely on the new nRF54 support. There are a couple of things but nothing major 🙂 - we look forward to landing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a step in the right direction, nice work! Most of our review notes this round are stylistic in nature.
Please drop target/
from your commit messages as, per the contribution guidelines, it's not to be included in the prefix.
After those things have been taken care of we think this'll be ready for merge so we can get early nRF54L support in 😄
MDM is a NXP-specific term, Nordic calls it a CTRL-AP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging. Thank you for the contribution!
Detailed description
This PR adds support for nRF54L.
The functionality of this PR has been tested through an automated test script published here:
Your checklist for this pull request
Closing issues
N/A