Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nRF54L #2009

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add support for nRF54L #2009

merged 2 commits into from
Dec 3, 2024

Conversation

zyp
Copy link
Contributor

@zyp zyp commented Dec 1, 2024

Detailed description

This PR adds support for nRF54L.

The functionality of this PR has been tested through an automated test script published here:

image

Your checklist for this pull request

Closing issues

N/A

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already had a bit of a chat on Discord about the adi.c and adiv5.c changes and how to evolve those, so this review is purely on the new nRF54 support. There are a couple of things but nothing major 🙂 - we look forward to landing this!

src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/nrf54l.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added the New Target New debug target label Dec 1, 2024
@zyp
Copy link
Contributor Author

zyp commented Dec 2, 2024

Review comments addressed, and I also improved the RRAM routines to use the write buffer, and added a benchmark to my test script to measure the performance:
image

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a step in the right direction, nice work! Most of our review notes this round are stylistic in nature.

Please drop target/ from your commit messages as, per the contribution guidelines, it's not to be included in the prefix.

After those things have been taken care of we think this'll be ready for merge so we can get early nRF54L support in 😄

src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/nrf54l.c Outdated Show resolved Hide resolved
src/target/adi.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v2.0 release milestone Dec 3, 2024
zyp added 2 commits December 3, 2024 09:49
MDM is a NXP-specific term, Nordic calls it a CTRL-AP.
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux merged commit e94242c into blackmagic-debug:main Dec 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Target New debug target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants