Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortexar: halt core in cortexar_mem_write #2012

Merged

Conversation

marysaka
Copy link
Contributor

@marysaka marysaka commented Dec 8, 2024

This seems to be an oversight, let's mirror whaT cortexar_mem_read does.

Detailed description

This seems to be an oversight, let's mirror whaT cortexar_mem_read does.

Your checklist for this pull request

Closing issues

This seems to be an oversight, let's mirror whaT cortexar_mem_read does.

Signed-off-by: Mary Guillemard <mary@mary.zone>
@marysaka marysaka force-pushed the fix/cortexar-memwrite-halt branch from d3d9837 to 2b4efc4 Compare December 8, 2024 20:42
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was indeed an oversight. LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Dec 8, 2024
@dragonmux dragonmux added the Bug Confirmed bug label Dec 8, 2024
@dragonmux dragonmux merged commit 2b4efc4 into blackmagic-debug:main Dec 8, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants