target: Support 64-bit address for break/wath point #2017
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
force-pushed
the
feature/breakpoint-64bit
branch
from
cd7f6b1 to
790ef87
Compare
This change breakwatch::addr to be 64-bit as this will be required for ARMv8 AArch64 support. This also change the layout of breakwatch to avoid extraneous padding in 64-bit and reduce the size of the reserved array to 64 bits. Signed-off-by: Mary Guillemard <mary@mary.zone>
marysaka
force-pushed
the
feature/breakpoint-64bit
branch
from
790ef87 to
9086642
Compare
6 tasks
dragonmux
requested changes
Dec 16, 2024
Comment on lines
-108
to
+107
| target_breakwatch_e type; | ||
| target_addr32_t addr; | ||
| target_addr64_t addr; |
There was a problem hiding this comment.
This reordering needs to be gated on sizeof(void *) - for the firmware, pointers are 32-bit so this mis-aligns the 64-bit int of addr, while this correctly aligns it on 64-bit platforms. Conditionally reordering the addr and type members is probably the right way forwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breakwatch::addr to be 64-bit as this will be required for ARMv8 AArch64 support.
This also change the layout of breakwatch to avoid extraneous padding in 64-bit and reduce the size of the reserved array to 64 bits.
Detailed description
Your checklist for this pull request
Closing issues