Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues with authentication flow #807

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

dermotduffy
Copy link
Collaborator

Fix two issues (both my fault):

  • In my reconfigure PR I referred to the wrong step, breaking translations.
  • In @loispostula 's auth PR, I suggested using None instead of empty strings -- turns out the frontend cannot serialize vol.Any(str, None), so this PR retreats to the use of empty strings which the frontend can serialize.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2800089) to head (8affacb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #807   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2140      2140           
=========================================
  Hits          2140      2140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dermotduffy dermotduffy merged commit 708d6b5 into blakeblackshear:master Dec 11, 2024
6 checks passed
@dermotduffy dermotduffy deleted the config-flow-fix branch December 11, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant