Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Because of the way we are using the custom hook for managing state with url parameters, there is no easy way to do a functional state update. Two calls to the update filter function in succession would be a race and the filter dropdown wouldn't always reflect the chosen state. This PR refactors the general review filter to only call the
onUpdateFilter
function once.This can be further improved by using
nuqs
and using the url parameters for state management, but that will require more work and testing.Type of change
Additional information
Checklist
ruff format frigate
)