Fix running blazium on blocked GPUs. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Those files are changing a lot, and I compare the godot master to blazium so i be able to see all the changes, we can update the authors file from 4.4 before we release to make sure we are crediting the contributers properly. |
Bioblaze
reviewed
Dec 3, 2024
Bioblaze
reviewed
Dec 3, 2024
WhalesState
force-pushed
the
fix-running-blazium-on-blocked-GPUs
branch
5 times, most recently
from
52165be to
aa692ae
Compare
…D projects if not supported.
…d in the editor system info.
Before it was a bit unclear on what was happening, since a display server has to fail to fall back and so the user would be left with an error _and_ a (hopefully) running game. Should make the experience more pleasant on Linux/BSD now that we have two display servers.
Before, they would always complain even if there was no attempt at initializing them (e.g. because there's no X11 display). While we're at it, this patch also adds a specific message for OpenGL ES and rewords "OpenGLES" to "OpenGL ES" in an error, for consistency (AFAIK we either say "GLES" or "OpenGL ES").
This brings it to parity with the X11 backend.
Godot checks if there's Vulkan or GLES3 support. If no support is found, it shows an error message. However the code for this error message is left out when building with opengl3=no
WhalesState
force-pushed
the
fix-running-blazium-on-blocked-GPUs
branch
2 times, most recently
from
6ab8000 to
012c604
Compare
WhalesState
force-pushed
the
fix-running-blazium-on-blocked-GPUs
branch
from
012c604 to
5e53efc
Compare
WhalesState
commented
Dec 3, 2024
There was a problem hiding this comment.
Reviewed and removed the RenderingContextDriverMetal from display_driver_macos.mm.
@jss2a98aj Thank You for helping and many thanks to the authors of the commits ^
Ughuuu
approved these changes
Dec 3, 2024
jss2a98aj
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch from godot 4.4.