Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazium rebranding started .md, and .github should be good to go #3

Conversation

RandomOfNoWhere
Copy link

No description provided.

-Left in SCsub "from misc.utility.scons_hints import *" change as this should not have any negative effect at this time
@RandomOfNoWhere
Copy link
Author

I'm done for the evening please review the commit that was added to this pull request:

9c8749d

-Restored " " in the builds.yml
-Fixed issue with version.h typo
Set base branch back to the correct branch
Left over redot remains
@KoltPenny
Copy link

Just curious, why are there Redot remains and not Godot's?

@RandomOfNoWhere
Copy link
Author

If in the .md file, I'm passing the torch to another on this, I don't have the data needed to complete the documents at this time. :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Bioblaze
Copy link

Link for Discord: https://discord.gg/vmJMrGAcb2

-README.md: See linke 65, for the removed Redot Reference
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file and the pom,properties file changes something that was supposed to come with this commit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thank you

pom.xml Outdated Show resolved Hide resolved
Extra file that was not needed
Copyright changes will be handled via a script, hence this change has now been removed
Removed unneeded code
Removed unneeded code
Removed unneeded code
Removed unneeded code
Removed unneeded code
Items that are not needed at all in the project, were only intended for local use
This prevents netbeans local files from being pushed to the project
Removed unneeded change
Removed unneeded change
Removed unneeded change
Removed unneeded change
Removed unneeded change
Removed unneeded change
Removed unneeded change
@RandomOfNoWhere
Copy link
Author

Unsure of why the Linux build is failing here and not locally?
BuildsLocally

@RandomOfNoWhere
Copy link
Author

This PR will be cleaned and rebased, do not merge

@RandomOfNoWhere
Copy link
Author

Closed, a new PR will be made after the following actions are taken:
-Do not change comments that are still related to core GoDot code
-Either do not change translation files, or manually verify each string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants