Rebranding tests folder #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jss2a98aj
reviewed
Oct 17, 2024
| @@ -141,7 +141,7 @@ TEST_CASE("[Marshalls] Floating point double precision decoding") { | |||
| } | |||
|
|
|||
| TEST_CASE("[Marshalls] C string encoding") { | |||
| char cstring[] = "Godot"; // 5 characters | |||
| char cstring[] = "Blazium"; // 5 characters | |||
There was a problem hiding this comment.
"Blazium" is a little bit longer than 5 characters.
There was a problem hiding this comment.
On line 149 there's ca character size check. Checks every character. Didn't touch
Only did as instructed :D |
|
We're closing this, if you would like to contact us on Discord we can pick it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things left to look into that I did not touch:
tests/core/io/test_marshalls.h:149 - Godot name in number of characters
tests/core/io/test_packet_peer.h - file does not exist
tests/core/io/test_pck_packer.h:114 - length
tests/core/string/test_string.h
tests/core/string/test_string.h:1783 - TEST_CASE("[String] SHA1/SHA256/MD5") line count different, no checks on urls
image files to change: