forked from godotengine/godot
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand scenes patform folders v2 #8
Closed
Norrox
wants to merge
6
commits into
blazium-engine:blazium-rebranding
from
Norrox:rebrand-scenes-patform-folders-v2
Closed
Rebrand scenes patform folders v2 #8
Norrox
wants to merge
6
commits into
blazium-engine:blazium-rebranding
from
Norrox:rebrand-scenes-patform-folders-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murly117
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a few lines that were left over from the Redot PR that are not related to rebranding. Please validate one way or the other :)
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.expansion.downloader.patch
Show resolved
Hide resolved
platform/android/java/lib/patches/com.google.android.vending.licensing.patch
Show resolved
Hide resolved
i close this in favour of #12 |
Norrox
added a commit
to Norrox/blazium
that referenced
this pull request
Nov 16, 2024
Updates from godot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, so i firstly by mistake started to rebrand on the 4.3 stable fork instead of this one.
I cherry picked my commit but it came with a few merge error witch i think i solved.
please check for errors and tell me if something needs changing / removed / added
i might have renamed something i should not have...
It compiles fine on my linux machine
EDIT: And compiles to windows