handling edge cases in reconstruct API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey,
CascadingRadium and
Likith101
| } | ||
|
|
||
| // exit in case of invalid input | ||
| if n == 0 || len(recons) != int(n)*idx.D() { |
There was a problem hiding this comment.
Perhaps the n == 0 check should be moved up before the recons alloc - line 333.5.
There was a problem hiding this comment.
technically speaking this is still the first validation check, so i dont think it would cause issues if we keep it over here. (just that moving the n == 0 check will have three separate if conditions which wouldn't look good i guess)
the condition at 334 doesn't exit the function, since its for when some user doesn't know what exactly to give for recons (which is like a prealloc) - in which case the function explicitly allocs the slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.