-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index sections #165
Merged
Merged
Index sections #165
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
74bdaf9
prototype of index sections
mschoch 9ccb8e5
thoughts on refactoring the inv index to section code
Thejas-bhat 89991d8
refactoring 1/index as per sections interface - wip
Thejas-bhat f217f81
code cleanup and populating dictLocs and dv offsets
Thejas-bhat 3d37b27
resetting inverted index opaque values
Thejas-bhat 81a356f
bug fixes with respect to unit tests
Thejas-bhat afc0f2b
code cleanup; removing numeric range section
Thejas-bhat 943961a
notes on upgrade stuff
Thejas-bhat c88aa37
handling older file formats - wip
Thejas-bhat abc054d
using varint encoding for storing offsets
Thejas-bhat dd4d018
handling loadDvReaders for older file formats as well
Thejas-bhat 4184ccc
zap version change
Thejas-bhat 25fd426
init var for dv readers
Thejas-bhat 79e04c4
bug fix: loading the doc values for older index files
Thejas-bhat 037a94f
bug fix determing the correct portion of index file for sb.mem
Thejas-bhat bd6d08f
refactoring code, better reuse of objects
Thejas-bhat 35abf14
unit test fixes
Thejas-bhat 245215a
code comments and some naming changes
Thejas-bhat 69ff4fe
renaming vars, files and some refactoring of code
Thejas-bhat e49a45b
added licensing files
Thejas-bhat b8f406e
trimming mergeToWriter API signature
Thejas-bhat eb9eb11
using uint32 for docNum
Thejas-bhat 6ed2ef3
Sections code for vector search (#166)
Thejas-bhat b610c16
Merge branch 'master' into refactor-section
abhinavdangeti fdff547
docNum to be of type uint32 in section's Process(..)
abhinavdangeti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come the fieldsIndexOffset and sectionsIndexOffset are the same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
essentially sections index content contains the same as fields index + sections information. so, for the fieldsIndexOffset which gives info about the fields in a segment we just consult the sectionsIndexOffset to get that info. Also, the field is needed for backward compatibility purposes as well.