MB-59692: Respect choice of similarity metric, bleve_index_api@v1.1.3 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
force-pushed
the
metric
branch
from
cabe3c2
to
394b0bf
Compare
abhinavdangeti
changed the title
Thejas-bhat
reviewed
Nov 17, 2023
| @@ -368,10 +368,15 @@ func (vo *vectorIndexOpaque) writeVectorIndexes(w *CountHashWriter) (offset uint | |||
| ids = append(ids, int64(hash)) | |||
| } | |||
|
|
|||
| var metric = faiss.MetricL2 | |||
| if content.metric == index.CosineSimilarity { | |||
There was a problem hiding this comment.
i feel like it would be a lot cleaner if we declare the map in the bleve_index_api domain as:
var SupportedSimilarityMetrics = map[string]int{
EuclideanDistance: faiss.MetricL2,
CosineSimilarity: faiss.MetricInnerProduct,
}
over here what we could do is pass the index.SupportedSimilarityMetrics[metric] value to the factory method
There was a problem hiding this comment.
Ya I thought about doing that earlier, but perhaps is not a good idea to pollute the generic bleve_index_api with implementation specifics - referring to go-faiss here, in case we decide to embed a different better performing vector index in the future.
Thejas-bhat
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.