Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-61890 - Introducing config at zap layer #256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

MB-61890 - Introducing config at zap layer #256

wants to merge 4 commits into from

Conversation

Thejas-bhat
Copy link
Member

@Thejas-bhat Thejas-bhat commented Aug 29, 2024 •
edited
Loading

  • The PR introduces the concept of config which can be index specific config values at the zap level. This would help in the future to perform any index specific tuning at the zap level.
  • This involves extending the existing interface's Open and New APIs.
  • The config is a member field in segmentBase struct but not persisted as part of segment format.

@Thejas-bhat Thejas-bhat marked this pull request as ready for review August 29, 2024 14:50
@metonymic-smokey metonymic-smokey changed the title Introducing config at zap layer MB-61890 - Introducing config at zap layer Aug 30, 2024
metonymic-smokey
metonymic-smokey reviewed Sep 11, 2024
View reviewed changes
segment.go Outdated
@@ -38,8 +38,18 @@ func init() {
reflectStaticSizeSegmentBase = int(unsafe.Sizeof(sb))
}

// Open returns a zap impl of a segment along with keeping some config values in
// mind during the segment's lifetime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think the "in mind" can be removed since we're dealing with segments here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonymic-smokey metonymic-smokey metonymic-smokey left review comments

@abhinavdangeti abhinavdangeti Awaiting requested review from abhinavdangeti

@CascadingRadium CascadingRadium Awaiting requested review from CascadingRadium

@Likith101 Likith101 Awaiting requested review from Likith101

@moshaad7 moshaad7 Awaiting requested review from moshaad7

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thejas-bhat @metonymic-smokey