-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade tanstack query to v5 #4360
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: efaa1df The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview tanstack-query-5 |
Snapshot Release tanstack-query-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update!
It would be great to read more about your thinking on when to use useQuery and when to use useSuspenseQuery from a Blitz-Tanstack-Query-Bestpractice point of view once this is lands.
<Suspense fallback={"Loading..."}> | ||
<Content /> | ||
</Suspense> | ||
<Content /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Suspense wrapper is gone, those two methods can be collapsed/made one, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we could, I just wanted to make as minimal changes to the integration tests to also test the useQuery
.
@tordans yeah for sure, I am working on a small writeup to post in the docs + in the release notes for this major |
Closes: #4188
What are the changes and their implications?
Feature Checklist
pnpm changeset
in the root directory)main
branch)