Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade tanstack query to v5 #4360

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

siddhsuresh
Copy link
Member

@siddhsuresh siddhsuresh commented Jul 16, 2024

Closes: #4188

What are the changes and their implications?

Feature Checklist

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: efaa1df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/next Major
@blitzjs/rpc Major
blitz Major
@blitzjs/auth Major
@blitzjs/codemod Major
@blitzjs/config Major
@blitzjs/generator Major
next-blitz-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddhsuresh siddhsuresh changed the title upgrade syntax to v5 feat: upgrade tanstack query to v5 Jul 16, 2024
@siddhsuresh
Copy link
Member Author

!preview tanstack-query-5

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Snapshot Release tanstack-query-5

@siddhsuresh siddhsuresh marked this pull request as ready for review November 22, 2024 07:08
Copy link
Contributor

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update!

It would be great to read more about your thinking on when to use useQuery and when to use useSuspenseQuery from a Blitz-Tanstack-Query-Bestpractice point of view once this is lands.

<Suspense fallback={"Loading..."}>
<Content />
</Suspense>
<Content />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the Suspense wrapper is gone, those two methods can be collapsed/made one, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we could, I just wanted to make as minimal changes to the integration tests to also test the useQuery.

@siddhsuresh
Copy link
Member Author

siddhsuresh commented Dec 20, 2024

It would be great to read more about your thinking on when to use useQuery and when to use useSuspenseQuery from a Blitz-Tanstack-Query-Bestpractice point of view once this is lands.

@tordans yeah for sure, I am working on a small writeup to post in the docs + in the release notes for this major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TanStackQuery v5 beta
4 participants