feat: add execute method to commands #17
Conversation
lukealvoeiro
changed the title
.execute(...) command.execute(...) method for commands
lukealvoeiro
force-pushed
the
lalvoeiro/execute-command
branch
from
42291be
to
4d65ce1
Compare
* main: fix: typo in exchange method `rewind` (#54) fix: remove unsafe pop of messages (#47) chore: Update LICENSE (#53) chore(docs): update is_dangerous_command method description (#48) refactor: improve safety rails speed and prompt (#45) feat: make goosehints jinja templated (#43) ci: enforce PR title follows conventional commit (#14) feat: show available toolkits (#37) adding in ability to provide per repo hints (#32) Apply ruff and add to CI (#40) added some regex based checks for dangerous commands (#38) chore: Update publish github workflow to check package versions before publishing (#19) chore: upgrade ai-exchange dependency (#36) fix: resuming sessions (#35) feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34) fix: export metadata.plugins export should have valid module (#30) fix (#24) link to vs code extension (#20) Enable cli options for plugin (#22) Modified the readme to be more friendly to new users (#16)
lukealvoeiro
force-pushed
the
lalvoeiro/execute-command
branch
from
bf39f0d
to
c26a5c9
Compare
lukealvoeiro
changed the title
.execute(...) method for commands
|
|
||
|
|
||
| def create_prompt() -> PromptSession: | ||
| def create_prompt(commands: dict[str, Command]) -> PromptSession: |
There was a problem hiding this comment.
I know this is an old function but can we get a docstring since it's part of your PR 🙏
There was a problem hiding this comment.
for sure, good call!
| @staticmethod | ||
| def create_prompt_session() -> "GoosePromptSession": | ||
| return GoosePromptSession(create_prompt()) | ||
| def get_message_after_commands(self, message: str) -> str: |
There was a problem hiding this comment.
I added some comments to make the flow of logic clearer to the uninitiated but feel free to ignore!
|
I am curious whether there is any real use case to use the command It would be good to have a clear purpose while we adding code as code maintenance could be a cost. |
|
@lifeizhou-ap we have the quorum toolkit which will be using this, as well as the file command. given this, that's why the ticket has a high priority on our internal Linear board. it's also a bit of a catch-22, where if we don't give engineers the ability to run commands, we won't see additional use-cases for it. |
|
Sorry for automated comments on this pull request. Goose used the current directory instead of the plugins repo to send these comments. |
About
Before this PR, commands would lexed in the following way:
After this PR, commands are lexed as so: