fix: Handle interrupt after tool response but before assistant message #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let prompt_response = "We interrupted before the model replied and removed the last message."; | ||
| self.prompt.render(raw_message(prompt_response)); | ||
| } | ||
| None => panic!("No content in last message"), |
There was a problem hiding this comment.
will this quit the whole agent or a child process?
There was a problem hiding this comment.
everything I imagine, but should never have a User message with no content, should be unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the interrupt came after a tool result but before the next assistant message the rewrite code would see the last message (tool result) with user role and remove it. This is the correct behavior if it was an actual user message but not for a tool result as it causes a mismatch in requests-results making the message request invalid.
This PR stops that behavior and adds a assistant message explaining the the tool calls were interrupted, what would the user like to do next.